Support int8 migration versions via new int8-versions feature#330
Support int8 migration versions via new int8-versions feature#330jxs merged 9 commits intorust-db:mainfrom
Conversation
mpalmer
force-pushed
the
int8-versions
branch
4 times, most recently
from
d8252fe to
1277e3e
Compare
This addresses, though does not really *fix* rust-db#83, because it doesn't make refinery support timestamped migrations *by default*, but only if you opt-in to the new feature. However, making it an optional feature neatly sidesteps the unanswered questions in the issue, and so makes the implementation easier to complete and land.
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Hi, and thanks for your interest! As I stated on #83 (comment) I'd rather this was not feature gated and instead a function was provided to migrate to int8. Would you be willing to do that instead?
Thanks
Not at the present time, no. As you identified in #83, there are unanswered design questions with migrating existing users to an int8 column, I don't use the CLI, and the approach in this PR Works For Me(TM). Perhaps one of the commenters from #83, such as @ankhers, might like to use this PR as a basis? |
jxs
force-pushed
the
int8-versions
branch
3 times, most recently
from
fb26681 to
666cbd3
Compare
You are right, this makes more sense as a feature that doesn't break everyone's previous code. I am sorry for the back and fourth, I have now fixed the merge conflicts for this to be merged. |
2 participants
This addresses, though does not really fix #83, because it doesn't make refinery support timestamped migrations by default, but only if you opt-in to the new feature. However, making it an optional feature neatly sidesteps the unanswered questions in the issue, and so makes the implementation easier to complete and land.